Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo alt text #546

Closed
viralanomaly opened this issue Jun 22, 2018 · 3 comments
Closed

Logo alt text #546

viralanomaly opened this issue Jun 22, 2018 · 3 comments
Labels
help wanted

Comments

@viralanomaly
Copy link
Contributor

Is there support for alt-text for the logo image we specify with x-logo?
@RomanHotsiy
Copy link
Member

Nice suggestion!
PRs are welcome!

@viralanomaly
Copy link
Contributor Author

I'm going to take a stab at this.

@viralanomaly
Copy link
Contributor Author

I have a fix for it, but when I run the tests out of paranoia (yarn test), the license check step is failing on an MIT license, which doesn't really make sense. Should I just ignore that problem since I certainly didn't introduce it?

@viralanomaly viralanomaly mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RomanHotsiy @viralanomaly