-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to PyDAS #339
Comments
I have some changes of my own on https://github.com/connie/PyDAS/commits/master allowing PyDAS to receive additional arguments so that the functional calls to both DASPK and DASSL can be the same and used interchangeably. If we are going to make the update we should probably do it altogether. |
Agree to making the changes all at once for RMG. |
I grabbed @connie's changes - I was thinking of making those changes too, so it was nice to find them already done! I'll probably merge it into my master soon, and then leave it to you guys to update GreenGroup/PyDAS so I don't interrupt any RMG work. As for backwards compatibility, making |
@jwallen has updated (or is updating) PyDAS with a change that will require:
See jwallen/PyDAS#12
Although the https://github.com/GreenGroup/PyDAS fork seems to be divorced form Josh's I suggest we merge his recent changes.
The text was updated successfully, but these errors were encountered: