Update router state properties directly #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +90,7 @@ const Router = React.createClass({ | |||
| } else { | |||
| // Keep the identity of this.router because of a caveat in ContextUtils: | |||
| // they only work if the object identity is preserved. | |||
| assign(this.router, this.createRouterObject(state)) | |||
| updateRouterObjectState(this.router, state) | |||
There was a problem hiding this comment.
Or call it something like assignRouterState and use it in createRouterObject as well.
There was a problem hiding this comment.
I wanted to keep the shape of router in one place, rather than having coupling to it's shape spread into two places.
There was a problem hiding this comment.
use it in createRouterObject as well
Oh, that's a good point. One sec...
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address the last checkbox on #3445
It will also shut me up about this comment #3445 (comment) 😄