Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get header version from URL instead of theme.conf #769

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: Get header version from URL instead of theme.conf #769

merged 3 commits into from
May 22, 2024

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented May 9, 2024 •
edited
Loading

to address #757

@samjwu samjwu added the enhancement New feature or request label May 9, 2024
@samjwu samjwu self-assigned this May 9, 2024
@samjwu samjwu marked this pull request as ready for review May 15, 2024 17:05
@samjwu samjwu requested review from lawruble13, saadrahim, eidenyoshida and a team May 15, 2024 17:05
@saadrahim
Copy link
Member

How does latest know what version it is?

@samjwu
Copy link
Member Author

samjwu commented May 15, 2024

How does latest know what version it is?

It grabs it from a file in the header-versions branch https://github.com/ROCm/rocm-docs-core/blob/header-versions/latest_version.txt

saadrahim
saadrahim previously requested changes May 15, 2024
View reviewed changes
Copy link
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this approach is suitable for offline environments.

src/rocm_docs/theme.py Outdated Show resolved Hide resolved
src/rocm_docs/theme.py Outdated Show resolved Hide resolved
@samjwu
Copy link
Member Author

samjwu commented May 15, 2024

I don't think this approach is suitable for offline environments.

No, but offline build functionality is also currently blocked by other features such as intersphinx

@saadrahim saadrahim dismissed their stale review May 15, 2024 23:08

Concerns addressed

@samjwu samjwu requested review from saadrahim and yhuiYH May 16, 2024 17:28
yhuiYH
yhuiYH approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@yhuiYH yhuiYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, approved

@samjwu samjwu merged commit 5c5c435 into ROCm:develop May 22, 2024
7 checks passed
@samjwu samjwu deleted the header branch May 22, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuiYH yhuiYH yhuiYH approved these changes

@lawruble13 lawruble13 Awaiting requested review from lawruble13

@eidenyoshida eidenyoshida Awaiting requested review from eidenyoshida

@saadrahim saadrahim Awaiting requested review from saadrahim

Assignees

@samjwu samjwu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samjwu @saadrahim @yhuiYH