Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "parse onnx graph for int4"" #3435

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Sep 11, 2024

Reverts #3434

@pfultz2
Copy link
Collaborator Author

pfultz2 commented Sep 11, 2024

We can merge this when CI is clear.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (7df8038) to head (3a7f1bf).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/onnx/onnx_parser.cpp 60.86% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3435      +/-   ##
===========================================
- Coverage    92.14%   92.11%   -0.04%     
===========================================
  Files          504      504              
  Lines        20508    20526      +18     
===========================================
+ Hits         18898    18907       +9     
- Misses        1610     1619       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten merged commit b873556 into develop Sep 12, 2024
20 of 23 checks passed
@causten causten deleted the revert-3434-revert-3408-lw/parse_onnx_int4 branch September 12, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants