Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addition of repo before zypper install command for sles docker #3401

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

ahsan-ca
Copy link
Contributor

Repo is added after zypper install command in the docker file.
Move the addition of repo in the file before install command.
This helps find packages listed in the install command.

@ahsan-ca ahsan-ca added the bugfix Fixes a bug found in the code. label Aug 24, 2024
@ahsan-ca ahsan-ca self-assigned this Aug 24, 2024
@ahsan-ca ahsan-ca requested a review from causten as a code owner August 24, 2024 07:52
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (c9bbea1) to head (ad5569c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3401   +/-   ##
========================================
  Coverage    92.25%   92.25%           
========================================
  Files          501      501           
  Lines        20087    20087           
========================================
  Hits         18531    18531           
  Misses        1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
ad5569
Rate old
c9bbea
Diff Compare
torchvision-resnet50 64 3,252.15 3,248.85 0.10%
torchvision-resnet50_fp16 64 6,998.99 6,994.67 0.06%
torchvision-densenet121 32 2,433.90 2,434.13 -0.01%
torchvision-densenet121_fp16 32 4,085.58 4,099.19 -0.33%
torchvision-inceptionv3 32 1,636.85 1,636.64 0.01%
torchvision-inceptionv3_fp16 32 2,738.25 2,738.23 0.00%
cadene-inceptionv4 16 776.08 776.33 -0.03%
cadene-resnext64x4 16 808.40 807.98 0.05%
slim-mobilenet 64 7,460.00 7,455.93 0.05%
slim-nasnetalarge 64 207.89 208.11 -0.11%
slim-resnet50v2 64 3,345.90 3,344.32 0.05%
bert-mrpc-onnx 8 1,146.97 1,151.68 -0.41%
bert-mrpc-tf 1 308.52 313.49 -1.59%
pytorch-examples-wlang-gru 1 418.39 426.29 -1.85%
pytorch-examples-wlang-lstm 1 382.15 388.27 -1.58%
torchvision-resnet50_1 1 764.83 798.93 -4.27% 🔴
cadene-dpn92_1 1 432.15 433.21 -0.25%
cadene-resnext101_1 1 374.08 379.24 -1.36%
onnx-taau-downsample 1 344.10 344.50 -0.12%
dlrm-criteoterabyte 1 35.06 35.05 0.04%
dlrm-criteoterabyte_fp16 1 58.00 58.09 -0.15%
agentmodel 1 7,984.54 7,760.12 2.89%
unet_fp16 2 58.05 58.07 -0.03%
resnet50v1_fp16 1 905.76 992.52 -8.74% 🔴
resnet50v1_int8 1 934.78 939.29 -0.48%
bert_base_cased_fp16 64 1,149.73 1,149.88 -0.01%
bert_large_uncased_fp16 32 355.18 355.25 -0.02%
bert_large_fp16 1 210.75 210.37 0.18%
distilgpt2_fp16 16 2,157.47 2,158.59 -0.05%
yolov5s 1 535.57 542.90 -1.35%
tinyllama 1 43.45 43.43 0.04%
vicuna-fastchat 1 171.62 171.27 0.20%
whisper-tiny-encoder 1 407.80 408.26 -0.11%
whisper-tiny-decoder 1 423.21 426.73 -0.83%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 934f087 into develop Aug 24, 2024
23 of 24 checks passed
@causten causten deleted the sles-docker-update branch August 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants