-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWDEV-451864 - Remove the hard coded path in MIGRAPHX_CXX_COMPILER #3377
base: develop
Are you sure you want to change the base?
Conversation
amdclang++/amdclang can be invoked without providing absolute path, since update-alternatives command has been run for these binaries This will also help to remove the hard coded paths in cmake target files for these compilers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3377 +/- ##
===========================================
- Coverage 92.26% 92.04% -0.23%
===========================================
Files 500 506 +6
Lines 20057 20872 +815
===========================================
+ Hits 18506 19212 +706
- Misses 1551 1660 +109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why this should be changed either as it doesnt affect any users. |
As part of our efforts to make ROCm relocatable , these hard coded paths need to be removed. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
amdclang++/amdclang can be invoked without providing absolute path, since update-alternatives command has been run for these binaries This will also help to remove the hard coded paths in cmake target files for these compilers