Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWDEV-451864 - Remove the hard coded path in MIGRAPHX_CXX_COMPILER #3377

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

raramakr
Copy link
Contributor

amdclang++/amdclang can be invoked without providing absolute path, since update-alternatives command has been run for these binaries This will also help to remove the hard coded paths in cmake target files for these compilers

amdclang++/amdclang can be invoked without providing absolute path, since update-alternatives command has been run for these binaries
This will also help to remove the hard coded paths in cmake target files for these compilers
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (01c94fa) to head (05eac04).
Report is 61 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3377      +/-   ##
===========================================
- Coverage    92.26%   92.04%   -0.23%     
===========================================
  Files          500      506       +6     
  Lines        20057    20872     +815     
===========================================
+ Hits         18506    19212     +706     
- Misses        1551     1660     +109     
Flag Coverage Δ
92.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfultz2
Copy link
Collaborator

pfultz2 commented Aug 15, 2024

This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why this should be changed either as it doesnt affect any users.

@raramakr
Copy link
Contributor Author

This should still use the absolute path so we can be sure its using the same compiler the developer set migraphx to build with. I dont see any reason why this should be changed either as it doesnt affect any users.

As part of our efforts to make ROCm relocatable , these hard coded paths need to be removed.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
05eac0
Rate old
e230c0
Diff Compare
torchvision-resnet50 64 3,239.39 3,249.77 -0.32%
torchvision-resnet50_fp16 64 6,878.90 6,987.71 -1.56%
torchvision-densenet121 32 2,429.95 2,431.48 -0.06%
torchvision-densenet121_fp16 32 4,084.29 4,103.92 -0.48%
torchvision-inceptionv3 32 1,634.62 1,637.67 -0.19%
torchvision-inceptionv3_fp16 32 2,736.73 2,744.19 -0.27%
cadene-inceptionv4 16 771.54 779.19 -0.98%
cadene-resnext64x4 16 807.62 808.74 -0.14%
slim-mobilenet 64 7,440.05 7,462.54 -0.30%
slim-nasnetalarge 64 207.46 208.50 -0.50%
slim-resnet50v2 64 3,340.64 3,435.17 -2.75%
bert-mrpc-onnx 8 1,152.72 1,150.08 0.23%
bert-mrpc-tf 1 308.02 314.23 -1.98%
pytorch-examples-wlang-gru 1 425.72 420.51 1.24%
pytorch-examples-wlang-lstm 1 388.40 495.59 -21.63% 🔴
torchvision-resnet50_1 1 801.92 770.67 4.05% 🔆
cadene-dpn92_1 1 434.30 402.30 7.95% 🔆
cadene-resnext101_1 1 380.85 381.59 -0.19%
onnx-taau-downsample 1 344.52 343.63 0.26%
dlrm-criteoterabyte 1 35.07 35.05 0.04%
dlrm-criteoterabyte_fp16 1 57.31 58.08 -1.32%
agentmodel 1 8,043.50 8,076.83 -0.41%
unet_fp16 2 57.78 57.92 -0.24%
resnet50v1_fp16 1 930.21 935.45 -0.56%
resnet50v1_int8 1 918.13 956.44 -4.01% 🔴
bert_base_cased_fp16 64 1,141.31 1,153.21 -1.03%
bert_large_uncased_fp16 32 351.55 355.68 -1.16%
bert_large_fp16 1 209.89 211.87 -0.93%
distilgpt2_fp16 16 2,152.62 2,159.18 -0.30%
yolov5s 1 504.55 533.70 -5.46% 🔴
tinyllama 1 43.43 43.69 -0.58%
vicuna-fastchat 1 172.59 172.04 0.32%
whisper-tiny-encoder 1 412.64 417.90 -1.26%
whisper-tiny-decoder 1 418.96 424.90 -1.40%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants