-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ci rocm6.2 #3340
Merged
Merged
Bump ci rocm6.2 #3340
Changes from 51 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
9291c01
Upgrade CI to 6.1.3
pfultz2 65cac2b
Build with clang to avoid linker errors with ubsan
pfultz2 c7d148f
Fix asan odr issues
pfultz2 f0ece94
Use same debug flags
pfultz2 2903290
Disable warning
pfultz2 79585c0
Add asan options
pfultz2 398adad
Just disable odr detection
pfultz2 be8b78a
Move to docker
pfultz2 de9b6b5
Set to 0
pfultz2 0cf5d32
Disable global reporting
pfultz2 2065d63
Use gcc for ASAN
pfultz2 00a658b
Switch back to clang
pfultz2 47a4480
Remove static since get_type_name is already static
pfultz2 b9386da
Try using a copy
pfultz2 ff70eb7
Format
pfultz2 15cbecf
log2 op (#3302)
aarushjain29 0d8e6a1
Update log2.cpp (#3338)
CharlieL7 72b7491
Bump ROCm version for CI and Docker to 6.2
2ede585
Update other dockers as well
d0d7593
Update CMakeLists.txt with changes from 6.1.3 update
a3f1ab5
Bitwise_and operator (#3321)
CharlieL7 a9c15f1
Stable Diffusion Models bump to torch 2.4.0 from 2.1.0 (#3344)
richagadgil 32153b6
Fix reshapes when lowering for CPU backend (#3346)
umangyadav ba101e1
Allow multiple outputs for the MLIR + Pointwise fusions (#3299)
umangyadav e65760a
Use new args each time in eliminate_contiguous (#3345)
umangyadav 51b5bca
Add ONNX parsing for SimplifiedLayerNormalization (#3129)
turneram eba3930
Update docker build with official released torch packages from repo.r…
a70ed4b
Merge branch 'develop' into bump_ci_rocm6.2
pfultz2 7b6da01
Merge branch 'develop' into bump_ci_rocm6.2
TedThemistokleous 42d5160
remove changes from config and name headers
181489d
Regen files
TedThemistokleous a9911b5
Update license for files
TedThemistokleous 588a329
Get around broken hipcc message for tidy/cppcheck
TedThemistokleous fc32fe7
Merge branch 'develop' into bump_ci_rocm6.2
causten 73c846b
Remove export for hipCC executable
TedThemistokleous 4619d7b
Merge branch 'develop' into bump_ci_rocm6.2
TedThemistokleous 763c39b
Update hipcc line to env instead
TedThemistokleous 94f10e7
Workaround for hipcc
ffcd9c0
Merge branch 'develop' into bump_ci_rocm6.2
TedThemistokleous 942945e
Sed delete out hipconfig as well as apply change to other dockers as …
6fe2a02
remove workaround for hipcc from sles docker for now
c2bf0d2
Remove entire WIN32 block in hip-clang.cmake
93e28e8
Add or true to sles workaround
cbcb054
Add hip-runtime-amd to hip-clang docker to solve CI issue
af25026
Try additional libs to see if this gets past error with hipcc
6f82c0c
replace if with HIP_PLATFORM being set already as workaround
14268da
Write in updated HIP_PLATFORM statement
b7ec938
Remove libs that are not needed
af7a9fb
Manually install hipcc remove workaround
355f663
Update ignore from tidy
5053237
workaround not needed in Dockerfile
causten aba657c
disable tidy issues
0bb51fc
turn lint off from line 27
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ ARG PREFIX=/usr/local | |
RUN dpkg --add-architecture i386 | ||
|
||
# Add rocm repository | ||
RUN sh -c 'echo deb [arch=amd64 trusted=yes] http://repo.radeon.com/rocm/apt/6.1.3/ focal main > /etc/apt/sources.list.d/rocm.list' | ||
RUN sh -c 'echo deb [arch=amd64 trusted=yes] http://repo.radeon.com/rocm/apt/6.2/ focal main > /etc/apt/sources.list.d/rocm.list' | ||
|
||
# From docs.amd.com for installing rocm. Needed to install properly | ||
RUN sh -c "echo 'Package: *\nPin: release o=repo.radeon.com\nPin-priority: 600' > /etc/apt/preferences.d/rocm-pin-600" | ||
|
@@ -28,6 +28,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --allow- | |
wget \ | ||
rocm-device-libs \ | ||
hip-dev \ | ||
hipcc \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be added to the install_preqs.sh. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved via #3469 |
||
libnuma-dev \ | ||
miopen-hip \ | ||
rocblas \ | ||
|
@@ -44,6 +45,9 @@ RUN ldconfig | |
# Workaround broken miopen cmake files | ||
RUN sed -i 's,;/usr/lib/x86_64-linux-gnu/librt.so,,g' /opt/rocm/lib/cmake/miopen/miopen-targets.cmake | ||
|
||
# Workaround for broken hip-clang | ||
# RUN sed -i -e '/if(WIN32)/, /endif()/d' /opt/rocm/lib/cmake/hip/hip-config.cmake && sed -i -n 5p /opt/rocm/lib/cmake/hip/hip-config.cmake | ||
|
||
ENV LC_ALL=C.UTF-8 | ||
ENV LANG=C.UTF-8 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #3470