Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verify namespace #1952

Merged
merged 3 commits into from
Jul 16, 2023
Merged

add verify namespace #1952

merged 3 commits into from
Jul 16, 2023

Conversation

umangyadav
Copy link
Member

@umangyadav umangyadav commented Jul 13, 2023

clone of #1939

For some reason when i pushed after rebase, it closed earlier PR. I probably messed up rebase

@umangyadav umangyadav requested review from TedThemistokleous and CharlieL7 and removed request for TedThemistokleous July 13, 2023 18:33
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1952 (1e256d7) into develop (c4765a6) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 1e256d7 differs from pull request most recent head d70a0d7. Consider uploading reports for the commit d70a0d7 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1952   +/-   ##
========================================
  Coverage    91.37%   91.37%           
========================================
  Files          420      420           
  Lines        15593    15593           
========================================
  Hits         14248    14248           
  Misses        1345     1345           
Impacted Files Coverage Δ
src/include/migraphx/verify.hpp 56.41% <ø> (ø)
src/verify_args.cpp 0.00% <0.00%> (ø)

@umangyadav umangyadav self-assigned this Jul 14, 2023
@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jul 14, 2023

Test Batch Rate new
d70a0d
Rate old
c4765a
Diff Compare
torchvision-resnet50 64 895.29 895.59 -0.03%
torchvision-resnet50_fp16 64 5,315.66 5,311.25 0.08%
torchvision-densenet121 32 1,126.78 1,126.27 0.04%
torchvision-densenet121_fp16 32 3,280.15 3,282.35 -0.07%
torchvision-inceptionv3 32 592.49 592.81 -0.05%
torchvision-inceptionv3_fp16 32 2,510.85 2,491.98 0.76%
cadene-inceptionv4 16 328.82 329.89 -0.33%
cadene-resnext64x4 16 395.95 395.64 0.08%
slim-mobilenet 64 7,133.35 7,137.84 -0.06%
slim-nasnetalarge 64 159.97 159.97 0.00%
slim-resnet50v2 64 1,089.88 1,090.40 -0.05%
bert-mrpc-onnx 8 719.50 719.09 0.06%
bert-mrpc-tf 1 371.34 370.46 0.24%
pytorch-examples-wlang-gru 1 302.50 302.34 0.05%
pytorch-examples-wlang-lstm 1 309.00 309.30 -0.10%
torchvision-resnet50_1 1 91.95 91.89 0.06%
torchvision-inceptionv3_1 1 129.24 128.93 0.24%
cadene-dpn92_1 1 335.59 336.95 -0.40%
cadene-resnext101_1 1 237.60 237.34 0.11%
slim-vgg16_1 1 53.37 53.39 -0.04%
slim-mobilenet_1 1 1,503.46 1,501.74 0.11%
slim-inceptionv4_1 1 101.52 101.71 -0.19%
onnx-taau-downsample 1 316.65 316.49 0.05%
dlrm-criteoterabyte 1 21.44 21.44 0.00%
dlrm-criteoterabyte_fp16 1 39.98 39.99 -0.05%
agentmodel 1 5,833.42 5,884.19 -0.86%
unet_fp16 2 53.54 53.56 -0.04%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten merged commit 68a9a23 into develop Jul 16, 2023
11 checks passed
@causten causten deleted the verify_ns branch July 16, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants