-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add verify namespace #1952
Merged
add verify namespace #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
requested review from
TedThemistokleous and
CharlieL7
and removed request for
TedThemistokleous
July 13, 2023 18:33
TedThemistokleous
approved these changes
Jul 13, 2023
pfultz2
approved these changes
Jul 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1952 +/- ##
========================================
Coverage 91.37% 91.37%
========================================
Files 420 420
Lines 15593 15593
========================================
Hits 14248 14248
Misses 1345 1345
|
This build is OK for merge ✅ |
🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone of #1939
For some reason when i pushed after rebase, it closed earlier PR. I probably messed up rebase