Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Update MLIR usage to account for upstream merge #1924

Merged
merged 8 commits into from
Jul 13, 2023

Conversation

krzysz00
Copy link
Contributor

@krzysz00 krzysz00 commented Jul 7, 2023

This can be freely rolled into any other commit, and is published to allow the rocMLIR CI (which builds rocMLIR tip against MIGraphX tip) to pass.

This can be freely rolled into any other commit, and is published to
allow the rocMLIR CI (which builds rocMLIR tip against MIGraphX tip)
to pass.
@krzysz00 krzysz00 requested a review from manupak July 7, 2023 15:25
@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jul 8, 2023

Test Batch Rate new
9a2fe9
Rate old
e1039a
Diff Compare
torchvision-resnet50 64 895.78 895.60 0.02%
torchvision-resnet50_fp16 64 5,313.50 5,320.25 -0.13%
torchvision-densenet121 32 1,127.00 1,126.40 0.05%
torchvision-densenet121_fp16 32 3,280.18 3,281.17 -0.03%
torchvision-inceptionv3 32 594.00 593.14 0.14%
torchvision-inceptionv3_fp16 32 2,518.26 2,526.73 -0.34%
cadene-inceptionv4 16 329.44 329.27 0.05%
cadene-resnext64x4 16 393.64 396.82 -0.80%
slim-mobilenet 64 7,138.99 7,139.06 -0.00%
slim-nasnetalarge 64 159.92 159.89 0.02%
slim-resnet50v2 64 1,090.18 1,090.04 0.01%
bert-mrpc-onnx 8 719.91 719.56 0.05%
bert-mrpc-tf 1 369.67 371.35 -0.45%
pytorch-examples-wlang-gru 1 304.54 302.96 0.52%
pytorch-examples-wlang-lstm 1 309.90 308.58 0.43%
torchvision-resnet50_1 1 91.69 92.00 -0.33%
torchvision-inceptionv3_1 1 129.21 129.58 -0.29%
cadene-dpn92_1 1 334.89 326.43 2.59%
cadene-resnext101_1 1 237.11 236.57 0.23%
slim-vgg16_1 1 53.39 53.38 0.03%
slim-mobilenet_1 1 1,476.97 1,509.04 -2.13%
slim-inceptionv4_1 1 102.40 102.40 -0.00%
onnx-taau-downsample 1 316.74 316.01 0.23%
dlrm-criteoterabyte 1 21.42 21.43 -0.05%
dlrm-criteoterabyte_fp16 1 39.96 39.95 0.03%
agentmodel 1 5,866.89 5,609.50 4.59% 🔆
unet_fp16 2 53.57 53.54 0.05%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1924 (e265f6c) into develop (4edf119) will not change coverage.
The diff coverage is n/a.

❗ Current head e265f6c differs from pull request most recent head ac546df. Consider uploading reports for the commit ac546df to get more accurate results

@@           Coverage Diff            @@
##           develop    #1924   +/-   ##
========================================
  Coverage    91.37%   91.37%           
========================================
  Files          420      420           
  Lines        15593    15593           
========================================
  Hits         14248    14248           
  Misses        1345     1345           

@krzysz00 krzysz00 marked this pull request as ready for review July 12, 2023 17:57
@krzysz00 krzysz00 requested a review from pfultz2 July 12, 2023 17:57
@krzysz00 krzysz00 added the skip bot checks Skips the Performance and Accuracy CI tests label Jul 13, 2023
@krzysz00
Copy link
Contributor Author

This PR is meaningfully supersceded by #1899 , since that PR incorporates these changes and also adds multithreading support.

@causten causten merged commit c4765a6 into develop Jul 13, 2023
10 checks passed
@causten causten deleted the upstream-merge-changes-rocmlir branch July 13, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants