Fix literal rounding in codegen functions #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahmed10
added
bugfix
Codecov Report
@@ Coverage Diff @@
## develop #1910 +/- ##
========================================
Coverage 91.37% 91.37%
========================================
Files 419 419
Lines 15544 15544
========================================
Hits 14204 14204
Misses 1340 1340
|
TedThemistokleous
approved these changes
Jun 30, 2023
pfultz2
reviewed
Jun 30, 2023
test/gpu/codegen_literal.cpp
Outdated
| #include "migraphx/op/mul.hpp" | ||
| #include <iostream> | ||
| #include <vector> | ||
| #include <migraphx/operators.hpp> |
There was a problem hiding this comment.
Dont include this header.
pfultz2
reviewed
Jun 30, 2023
test/gpu/codegen_literal.cpp
Outdated
| #include <migraphx/program.hpp> | ||
| #include <migraphx/register_target.hpp> | ||
| #include <migraphx/verify.hpp> | ||
| #include <migraphx/pass_manager.hpp> |
There was a problem hiding this comment.
Is this needed? I dont see it using passes.
There was a problem hiding this comment.
Probably not, going to clean up and remove unneeded headers
pfultz2
reviewed
Jun 30, 2023
test/gpu/codegen_literal.cpp
Outdated
| // and after rounding must equal 63, not 64. | ||
| TEST_CASE(mul_literal_round_test) | ||
| { | ||
| auto run_prog = [](migraphx::program p, |
There was a problem hiding this comment.
Make this a free function.
pfultz2
reviewed
Jun 30, 2023
test/gpu/codegen_literal.cpp
Outdated
| result.visit([&](auto v) { res.assign(v.begin(), v.end()); }); | ||
| }; | ||
|
|
||
| auto create_program = [&] { |
pfultz2
reviewed
Jun 30, 2023
test/gpu/codegen_literal.cpp
Outdated
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ | ||
| #include "migraphx/op/mul.hpp" |
There was a problem hiding this comment.
Dont include this header.
|
Is it possible to add a TEST_CASE(literal_to_string_float_precision)
{
migraphx::literal x{1 / 0.00787402f};
EXPECT(x.to_string() == "126.99993142003703");
}This can probably go in |
Seems like this test fails because the string value doesn't match directly. I think I will rewrite it so it checks that the number doesn't round up. |
Check results before merge 🔆 |
🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output |
pfultz2
approved these changes
Jul 5, 2023
umangyadav
reviewed
Jul 5, 2023
| // and after rounding must equal 63, not 64. | ||
| TEST_CASE(mul_literal_round_test) | ||
| { | ||
|
|
| { | ||
| if(m_in.count(x.first) > 0) | ||
| { | ||
| m[x.first] = t.copy_to(m_in[x.first]); |
There was a problem hiding this comment.
I think you can call to set_offload_copy to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing test case in #1815. Added a test that would otherwise fail without the change.