Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: make clang-tidy optional if the tool is not found #1895

Closed
wants to merge 1 commit into from

Conversation

apwojcik
Copy link
Collaborator

The PR from the series to enable MIGraphX on Windows.

Copy link
Collaborator

@pfultz2 pfultz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in rocm-cmake. Its fine to merge it into the UIF branch, but we wont merge it into develop.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1895 (f34d72a) into develop (84a8f45) will not change coverage.
The diff coverage is n/a.

❗ Current head f34d72a differs from pull request most recent head 358ba8f. Consider uploading reports for the commit 358ba8f to get more accurate results

@@           Coverage Diff            @@
##           develop    #1895   +/-   ##
========================================
  Coverage    91.44%   91.44%           
========================================
  Files          419      419           
  Lines        15516    15516           
========================================
  Hits         14188    14188           
  Misses        1328     1328           

@apwojcik apwojcik closed this Jun 28, 2023
@apwojcik
Copy link
Collaborator Author

merged to rocm-cmake

@apwojcik apwojcik deleted the clang_tidy_optional branch June 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants