Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cached docker images from Github Runners #1874

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Remove cached docker images from Github Runners #1874

merged 8 commits into from
Jul 7, 2023

Conversation

umangyadav
Copy link
Member

@umangyadav umangyadav commented Jun 23, 2023 •
edited
Loading

Github Runners comes with pre-cached docker images
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#cached-docker-images
MIGraphX CI doesn't require any of those, hence remove them.

Looks like it is adding 17-21s for cleaning of docker images.

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@c1b8c97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4e4bf8b differs from pull request most recent head b78f880. Consider uploading reports for the commit b78f880 to get more accurate results

@@            Coverage Diff             @@
##             develop    #1874   +/-   ##
==========================================
  Coverage           ?   91.36%           
==========================================
  Files              ?      420           
  Lines              ?    15554           
  Branches           ?        0           
==========================================
  Hits               ?    14211           
  Misses             ?     1343           
  Partials           ?        0

@umangyadav umangyadav self-assigned this Jun 23, 2023
@umangyadav umangyadav added the skip bot checks Skips the Performance and Accuracy CI tests label Jun 26, 2023
@umangyadav
Copy link
Member Author

https://github.com/jlumbroso/free-disk-space/pull/5/files

This got merged. I'll update PR wrt to that.

@TedThemistokleous TedThemistokleous added enhancement New feature or request Continous Integration Pull request updates parts of continous integration pipeline labels Jul 7, 2023
@causten causten merged commit c88d4a5 into develop Jul 7, 2023
11 checks passed
@causten causten deleted the remove_docker branch July 7, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfultz2 pfultz2 pfultz2 approved these changes

@causten causten causten approved these changes

@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes

Assignees

@umangyadav umangyadav

Labels
Continous Integration Pull request updates parts of continous integration pipeline enhancement New feature or request skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umangyadav @pfultz2 @causten @TedThemistokleous