Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic shape ref clip operator #1862

Merged
merged 8 commits into from
Jul 2, 2023
Merged

Dynamic shape ref clip operator #1862

merged 8 commits into from
Jul 2, 2023

Conversation

CharlieL7
Copy link
Collaborator

  • Updates ref version of clip to work with dynamic shapes
  • Encountered in agentmodel

@CharlieL7 CharlieL7 self-assigned this Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1862 (9dfe1fb) into develop (3c9df3b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9dfe1fb differs from pull request most recent head 20a953a. Consider uploading reports for the commit 20a953a to get more accurate results

@@           Coverage Diff            @@
##           develop    #1862   +/-   ##
========================================
  Coverage    91.39%   91.39%           
========================================
  Files          419      419           
  Lines        15542    15542           
========================================
  Hits         14204    14204           
  Misses        1338     1338           
Impacted Files Coverage Δ
src/common.cpp 98.88% <ø> (ø)
src/include/migraphx/op/clip.hpp 100.00% <100.00%> (ø)

@CharlieL7 CharlieL7 added the simple small or simple changes label Jun 21, 2023
@CharlieL7 CharlieL7 marked this pull request as ready for review June 21, 2023 22:04
@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jun 28, 2023

Test Batch Rate new
20a953
Rate old
6696d4
Diff Compare
torchvision-resnet50 64 894.88 894.85 0.00%
torchvision-resnet50_fp16 64 5,306.58 5,313.14 -0.12%
torchvision-densenet121 32 1,125.08 1,123.99 0.10%
torchvision-densenet121_fp16 32 3,278.69 3,275.44 0.10%
torchvision-inceptionv3 32 593.05 592.96 0.02%
torchvision-inceptionv3_fp16 32 2,520.86 2,494.23 1.07%
cadene-inceptionv4 16 329.86 328.70 0.35%
cadene-resnext64x4 16 394.71 396.92 -0.56%
slim-mobilenet 64 7,121.31 7,132.06 -0.15%
slim-nasnetalarge 64 159.83 159.84 -0.01%
slim-resnet50v2 64 1,089.90 1,089.43 0.04%
bert-mrpc-onnx 8 718.82 718.90 -0.01%
bert-mrpc-tf 1 371.56 369.81 0.47%
pytorch-examples-wlang-gru 1 296.43 294.66 0.60%
pytorch-examples-wlang-lstm 1 307.06 298.45 2.89%
torchvision-resnet50_1 1 91.55 91.44 0.12%
torchvision-inceptionv3_1 1 129.33 128.98 0.27%
cadene-dpn92_1 1 334.83 333.88 0.29%
cadene-resnext101_1 1 236.61 236.49 0.05%
slim-vgg16_1 1 53.37 53.34 0.06%
slim-mobilenet_1 1 1,472.53 1,485.31 -0.86%
slim-inceptionv4_1 1 101.42 101.96 -0.53%
onnx-taau-downsample 1 315.87 316.36 -0.15%
dlrm-criteoterabyte 1 21.38 21.42 -0.21%
dlrm-criteoterabyte_fp16 1 39.86 39.95 -0.22%
agentmodel 1 5,706.13 5,413.13 5.41% 🔆
unet_fp16 2 52.73 52.63 0.19%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


    :white_check_mark:bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

    :white_check_mark:bert-mrpc-tf: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

    :white_check_mark:pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output


    :white_check_mark:cadene-resnext101_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-vgg16_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-mobilenet_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

    :white_check_mark:dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

    :white_check_mark:agentmodel: PASSED: MIGraphX meets tolerance

    :white_check_mark:unet: PASSED: MIGraphX meets tolerance

@causten causten merged commit 3f56688 into develop Jul 2, 2023
11 checks passed
@causten causten deleted the dyn_clip branch July 2, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants