-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to ck integration #1859
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1859 +/- ##
========================================
Coverage 91.39% 91.39%
========================================
Files 419 419
Lines 15542 15542
========================================
Hits 14204 14204
Misses 1338 1338 |
@@ -185,7 +203,10 @@ void par_compile(std::size_t n, F f) | |||
{ | |||
if(n == 0) | |||
return; | |||
par_for(n, n / value_of(MIGRAPHX_GPU_COMPILE_PARALLEL{}, n), f); | |||
auto d = value_of(MIGRAPHX_GPU_COMPILE_PARALLEL{}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto d = value_of(MIGRAPHX_GPU_COMPILE_PARALLEL{}); | |
auto d = value_of(MIGRAPHX_GPU_COMPILE_PARALLEL{}, n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That wont work, because the n
will be cached when MIGRAPHX_GPU_COMPILE_PARALLEL
is not set.
This build is not recommended to merge 🔴 |
🔴cadene-dpn92_1: FAILED: MIGraphX is not within tolerance - check verbose output |
@turneram Any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to leave int32 enabled, then adding the requirement that m, n, and k are all divisible by 4 appears to maintain correctness. We could also investigate further to get more precise criteria and then add it back in another PR.
MIGRAPHX_TUNE_CK
env variable to only do tuning for CK