Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small improvements #82

Merged
merged 1 commit into from
Apr 6, 2023
Merged

A few small improvements #82

merged 1 commit into from
Apr 6, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Apr 5, 2023

I've had this branch sitting locally for a while; I think it's time to contribute it.

  • Use appropriate exceptions instead of AttributeError
  • Use tuple unpacking rather than indexing (will catch errors better)
  • raise NotImplementedError for methods not implemented
  • Remove double variable assignment in docs/conf.py

I've had this branch sitting locally for a while; I think it's
time to contribute it.

- Use approprite exceptions instead of `AttributeError`
- Use tuple unpacking rather than indexing
- raise `NotImplementedError` for methods not implemented
- Remove double variable assignment in `docs/conf.py`
@coveralls
Copy link

coveralls commented Apr 5, 2023

Pull Request Test Coverage Report for Build 4620590636

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on small-improvements at 84.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_ground_state_solver.py 2 6 33.33%
Totals Coverage Status
Change from base Build 4620488455: 84.7%
Covered Lines: 1524
Relevant Lines: 1799

💛 - Coveralls

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@garrison garrison merged commit 041558c into main Apr 6, 2023
@garrison garrison deleted the small-improvements branch April 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants