Add a supported_gates function #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleb-johnson
added
cutting
Pull Request Test Coverage Report for Build 5338168393
💛 - Coveralls |
3 tasks
garrison
reviewed
Jun 21, 2023
Co-authored-by: Jim Garrison <garrison@ibm.com>
caleb-johnson
added a commit
that referenced
this pull request
Jun 21, 2023
* Add a supported_gates function * use sets instead of tuples * Fix docstring * Add release note * Fix test * Update circuit_knitting/cutting/qpd/qpd.py Co-authored-by: Jim Garrison <garrison@ibm.com> * Add new function to package and sphinx docs --------- Co-authored-by: Jim Garrison <garrison@ibm.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be a central place where users can find out whether or not a gate is supported without using a
tryblock and queryingqpdbasis_from_gate. I've addressed this here with a simple function that returns a hard-codedset. I had also considered a function which takes a gate as input and returns abool, but I just think this implementation is better for both the dev and user.