Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable monthly dependabot updates for the linters #114

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

garrison
Copy link
Member

This enables monthly dependabot updates for all packages whose versions are precisely pinned in pyproject.toml, which for us is various linters. This way, we will have a sense of (i) which linters have updates available; (ii) which linters can be updated immediately without causing any errors; and (iii) when a linter can't be immediately updated, an automated CI log of what first needs to be fixed. I believe monthly is the appropriate cadence for these checks; I really don't want to be bothered more often than that with linter updates, but I don't want them to get way out of date either without us noticing.

One thing that might become annoying is various black updates, but if that occurs we can later tell dependabot to ignore them.

I first experimented with this on a personal fork of ckt. See here for the activity that dependabot created on my repository. The only difference with this PR is that the PRs here (and there going forward) will have the label dependencies but not the label python, since labels is explicitly provided in the yml.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 4684976614

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.59%

Totals Coverage Status
Change from base Build 4672713865: 0.0%
Covered Lines: 1515
Relevant Lines: 1791

💛 - Coveralls

@garrison garrison added the on hold Let's wait for something before merging label Apr 13, 2023
@garrison
Copy link
Member Author

I added the "on hold" label to this. I think we want to wait until some of the current milestones are met before messing with the linters.

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

@garrison garrison added code quality Related to style, linters, etc. and removed on hold Let's wait for something before merging labels May 8, 2023
@garrison
Copy link
Member Author

I'm going to merge this now that we have the code migration done. We can always ignore the resulting dependabot PRs if they look like they will require substantial changes. (I doubt they will.)

@garrison garrison merged commit bd36a17 into main May 12, 2023
@garrison garrison deleted the dependabot-linters branch May 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to style, linters, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants