Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker notebook tests #113

Merged
merged 5 commits into from
May 5, 2023
Merged

Add Docker notebook tests #113

merged 5 commits into from
May 5, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Apr 13, 2023

The goal here is to test the docker-compose workflow once a week. My plan is to not have the test run upon every PR, unless that PR touches the Dockerfile or docker-compose.yml. In general, if all tests pass in CI, they should pass in Docker too. However, I also think that testing once a week inside Docker as a sanity check will help us make sure the Docker setup is not broken for long, if/when it does break (ahem, #112). If we wanted more frequent testing, we could make it happen daily instead, but then I feel we might be more distracted by intermittent failures than it is worth.

Action items

@github-actions
Copy link

github-actions bot commented Apr 13, 2023

Pull Request Test Coverage Report for Build 4690932665

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.59%

Totals Coverage Status
Change from base Build 4689211493: 0.0%
Covered Lines: 1515
Relevant Lines: 1791

💛 - Coveralls

@garrison garrison marked this pull request as ready for review April 13, 2023 14:52
@garrison
Copy link
Member Author

garrison commented Apr 13, 2023

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be any benefit of running this on both ubuntu and windows, due to some of the hardware architecture snafus we've run into?

@garrison
Copy link
Member Author

garrison commented May 5, 2023

Would there be any benefit of running this on both ubuntu and windows, due to some of the hardware architecture snafus we've run into?

I suspect not. The Windows test runners will still have the same hardware as the Ubuntu ones. It'd be nice if we could test on an M1 Mac, but that is not available, and as long as we have the line added in #71 we should be good.

@garrison garrison merged commit 258a68c into main May 5, 2023
@garrison garrison deleted the docker-notebook-tests branch May 26, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants