-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker notebook tests #113
Conversation
Pull Request Test Coverage Report for Build 4690932665
💛 - Coveralls |
This borrows from `citation.yml`.
Here's a CI run where the tests failed (before #112 was merged): https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/actions/runs/4684847257/jobs/8301388506 Here's a CI run where the tests passed (after #112 was merged): https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/actions/runs/4689224708/jobs/8310710653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be any benefit of running this on both ubuntu and windows, due to some of the hardware architecture snafus we've run into?
I suspect not. The Windows test runners will still have the same hardware as the Ubuntu ones. It'd be nice if we could test on an M1 Mac, but that is not available, and as long as we have the line added in #71 we should be good. |
The goal here is to test the
docker-compose
workflow once a week. My plan is to not have the test run upon every PR, unless that PR touches theDockerfile
ordocker-compose.yml
. In general, if all tests pass in CI, they should pass in Docker too. However, I also think that testing once a week inside Docker as a sanity check will help us make sure the Docker setup is not broken for long, if/when it does break (ahem, #112). If we wanted more frequent testing, we could make it happen daily instead, but then I feel we might be more distracted by intermittent failures than it is worth.Action items