Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log_dir property #5537

Merged
merged 37 commits into from
Feb 2, 2021
Merged

Fix log_dir property #5537

merged 37 commits into from
Feb 2, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 15, 2021 •
edited
Loading

What does this PR do?

Fixes #5524

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 mentioned this pull request Jan 15, 2021
Closed
@rohitgr7 rohitgr7 marked this pull request as ready for review January 15, 2021 20:58
@rohitgr7 rohitgr7 added the bug Something isn't working label Jan 15, 2021
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Jan 15, 2021
@rohitgr7 rohitgr7 marked this pull request as draft January 16, 2021 19:57
@codecov
Copy link

codecov bot commented Jan 16, 2021 •
edited
Loading

Codecov Report

Merging #5537 (81b82c9) into master (69ea388) will decrease coverage by 0%.
The diff coverage is 92%.

@@           Coverage Diff           @@
##           master   #5537    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         134     134            
  Lines       10059    9917   -142     
=======================================
- Hits         9394    9251   -143     
- Misses        665     666     +1

@rohitgr7 rohitgr7 marked this pull request as ready for review January 16, 2021 21:46
@rohitgr7 rohitgr7 marked this pull request as draft January 16, 2021 21:47
@rohitgr7 rohitgr7 marked this pull request as ready for review January 16, 2021 22:22
awaelchli
awaelchli approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awaelchli awaelchli added the logger Related to the Loggers label Jan 17, 2021
@carmocca carmocca added the ready PRs ready to be merged label Jan 19, 2021
@mergify mergify bot removed the has conflicts label Jan 28, 2021
tchaton
tchaton approved these changes Jan 29, 2021
View reviewed changes
pytorch_lightning/loggers/wandb.py Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Feb 2, 2021

hey @williamFalcon mind review this. Already auto-updated bazillion times.

@Borda Borda merged commit 793fe73 into master Feb 2, 2021
@Borda Borda deleted the bugfix/log_dir_prop branch February 2, 2021 17:06
tchaton added a commit that referenced this pull request Feb 5, 2021
@rohitgr7 @tchaton
@Borda @mergify
Fix log_dir property (#5537)
3e4a41a 
* fix and update tests

* update with ModelCheckpoint

* chlog

* wip wandb fix

* all fixed

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 5, 2021
@rohitgr7 @tchaton
@Borda @mergify
Fix log_dir property (#5537)
78b4d2b 
* fix and update tests

* update with ModelCheckpoint

* chlog

* wip wandb fix

* all fixed

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Feb 5, 2021
@rohitgr7 @tchaton
@Borda @mergify
Fix log_dir property (#5537)
2abf469 
* fix and update tests

* update with ModelCheckpoint

* chlog

* wip wandb fix

* all fixed

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@borisdayma borisdayma mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1.x
Development

Successfully merging this pull request may close these issues.

Trainer property log_dir cannot be accessed before model is bound to trainer
7 participants
@rohitgr7 @awaelchli @Borda @carmocca @tchaton @justusschock @SkafteNicki