-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster Accuracy metric #2775
Faster Accuracy metric #2775
Conversation
Hello @Diuven! Thanks for updating this PR.
Comment last updated at 2020-08-06 07:45:04 UTC |
@SkafteNicki @Borda @PyTorchLightning/core-contributors I think we now have to decide if we want to use the given num_classes or the calculated ones (especially if they don't match). Opinions? |
This pull request is now in conflict... :( |
Codecov Report
@@ Coverage Diff @@
## master #2775 +/- ##
=======================================
+ Coverage 88% 90% +1%
=======================================
Files 78 78
Lines 7069 7086 +17
=======================================
+ Hits 6250 6371 +121
+ Misses 819 715 -104 |
Actually, I updated the code to do the same thing with the previous code when it gets different I think this behaviour (using the results only in the range specified by the But I do think that this is quite counter-intuitive, and removing it will make the function more clear and faster. We can just remove this behaviour for now and add it later on, with well designed structure. This depends on the core developers' opinions, so I'm willing to update the PR correspondingly. Please share your thoughts! 😃 |
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
I'm keep getting some pip install errors on CI test intermittently. Can someone check if some code of mine are causing such problems? |
@Diuven This keeps happening from time to time, although we don't know why. Usually retriggering helps (what I did now) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the last missing docstring line :)
What does this PR do?
Speeding up the Accuracy metric for classification tasks.
Fixes #2722
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃