Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove setup.py / setuptools support #1098

Closed
asottile opened this issue Apr 3, 2021 · 10 comments
Closed

Deprecate and remove setup.py / setuptools support #1098

asottile opened this issue Apr 3, 2021 · 10 comments

Comments

@asottile
Copy link
Member

asottile commented Apr 3, 2021

In GitLab by @asottile on May 22, 2019, 14:18

This mode requires flake8 to be installed as an egg. The general consensus I've seen is that python setup.py test / etc. are 👎

I'd like to deprecate and remove the direct setuptools functionality from flake8 -- this will improve the maintainability by eliminating yet another entrypoint

There's a fairly straightforward "fix" if someone wants to use flake8 in their setup.py manually which is either:

  1. limit to flake8<X.X (whichever version this gets removed in)
  2. add flake8 to setup_requires and invoke flake8 using the desired cli from setup.py
@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Jul 8, 2019, 15:21

mentioned in merge request !330

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Aug 1, 2019, 14:26

closed via merge request !330

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Aug 1, 2019, 14:26

mentioned in commit 4b72089

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Dec 13, 2019, 09:21

mentioned in merge request !394

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @jfinkhaeuser on May 31, 2020, 06:42

I can't say I'm a big fan of this. It (currently) makes flake8 the only tool in my build chain to require special treatment.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on May 31, 2020, 14:30

I can't say I'm a big fan of this. It (currently) makes flake8 the only tool in my build chain to require special treatment.

Get used to it. More and more tools are shuffling off setuptools support. Flake8's support for it was always crap to begin with so getting rid of it was the right choice.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @mikael27 on Jun 1, 2020, 02:31

I just now got pointed to this page which said that what I am doing is bad and that might very well be the case. Some suggestion of what I should be doing instead of using setup.py would be much appreciated.

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Jun 1, 2020, 04:42

I just now got pointed to this page which said that what I am doing is bad

No one said what you're doing or who you are is bad.

Some suggestion of what I should be doing instead of using setup.py would be much appreciated.

It's not the responsibility of the maintainers of this project to educate you about best practices

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @sigmavirus24 on Jun 1, 2020, 04:42

locked this issue

@asottile
Copy link
Member Author

asottile commented Apr 3, 2021

In GitLab by @asottile on Mar 29, 2021, 20:19

mentioned in merge request !470

@asottile asottile closed this as completed Apr 3, 2021
dochang added a commit to dochang/bumplus that referenced this issue Aug 23, 2021
dochang added a commit to dochang/bumplus that referenced this issue Aug 23, 2021
dochang added a commit to dochang/bumplus that referenced this issue Aug 23, 2021
@PyCQA PyCQA locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant