-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyout navigation not working properly[MAUI.Prism] Android #2820
Comments
While debugging what I found out is after doing _navigationService.NavigateAsync("NavigationPage/ViewB"). This recursive calling might be the issue here but I am not sure why its calling again or this is might be how things work in prims |
hi @SarthakB26, did you find a workaround for this issue? |
For now you can get FlyoutPage from Application.MainPage as FlyoutPage and then sets its detail page by yourself rather then through prism navigation service. |
Thanks. I did a short investigation and found the issue. This commit causes the issue: PrismLibrary/Prism.Maui@9113b7d if (!useModalNavigation.Value && !MvvmHelpers.HasNavigationPageParent(currentPage))
useModalNavigation = true; The FlyoutPage does not have a NavigationPage parent, that's why I guess instead of |
The solution was even simpler. I created a PR with the fix. And I added a new test that fails without my changes and succeeds with my changes. |
Doing _navigationService.NavigateAsync("NavigationPage/ViewB") From Flyout Page will result in opening ViewB as a push modal also no hamburger icon will be visible on ViewB page.
Steps To Reproduce
Testing on Latest Maui and Prism version
Maui Flyout works fine
Video attached of Sample Prism app
Android.Emulator.-.pixel_5_-_api_32_5554.2023-02-15.16-50-44.mp4
Please let me know if there is any workaround to fix this. Really important for migration
The text was updated successfully, but these errors were encountered: