Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Publish and Use an Element docs #426

Merged
12 commits merged into from
Feb 5, 2019
Merged

[docs] Publish and Use an Element docs #426

12 commits merged into from
Feb 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2019

Add docs for publishing and using a LitElement based web component. Includes polyfills info.

Fixes #397
Fixes #364

Staged here: https://20190117t133729-dot-polymer-lit-element.appspot.com

@ghost ghost requested a review from justinfagnani as a code owner January 10, 2019 21:00
@ghost ghost assigned justinfagnani Jan 10, 2019
@arthurevans
Copy link
Contributor

For some reason, the titles for the new sections don't seem to be showing up in the left nav.

@ghost
Copy link
Author

ghost commented Jan 17, 2019

@ghost
Copy link
Author

ghost commented Jan 17, 2019

@ghost ghost changed the title draft publish and use docs [docs] Publish and Use an Element docs Jan 17, 2019
@ghost ghost assigned graynorton and arthurevans Jan 17, 2019
@ghost ghost added this to the 1.0.0 milestone Jan 17, 2019
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/use.md Outdated Show resolved Hide resolved
docs/_guide/use.md Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 28, 2019

@justinfagnani Resolved the conversations so I could visually keep track of which ones I had updated - feel free to re-open any points.

@ghost
Copy link
Author

ghost commented Jan 28, 2019

docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
docs/_guide/publish.md Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 29, 2019

@ghost
Copy link
Author

ghost commented Jan 29, 2019

@bennypowers thx for feedback, re-worded & staged here https://20190129t135624-dot-polymer-lit-element.appspot.com/guide/use

Copy link
Contributor

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you add issues for things you don't address here, like mentioning the polymer tools?

docs/_guide/publish.md Show resolved Hide resolved
docs/_guide/use.md Show resolved Hide resolved
docs/_guide/use.md Outdated Show resolved Hide resolved
docs/_guide/use.md Outdated Show resolved Hide resolved
docs/_guide/use.md Show resolved Hide resolved
docs/_guide/use.md Show resolved Hide resolved
justinfagnani and others added 2 commits February 4, 2019 16:39
Co-Authored-By: katejeffreys <katejeffreys@google.com>
@ghost ghost merged commit a7148bc into master Feb 5, 2019
@ghost ghost deleted the tools-ai branch March 25, 2019 19:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants