-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make validate
and invalidate
protected
#290
Comments
I'd love to help get this closed as it looks like a blocker to 1.0.0! If you aren't already working on it, of course... This change is mainly updating:
to
and
to
and then making reference corrections across the repo, right? I'll get started on putting together PR, but look forward to any other desires around this in the interim! |
I could probably use some help with the README content, too! |
As I just saw it here: https://github.com/Polymer/lit-element/pull/276/files#diff-c5f280d12b2d91f8b89fe4ac3b6313d8R522 I think it will still be
to keep following the naming conventions (as real protected and private are probably still some time off for "plain" javascript 🙈 ) |
I guess it's a question of whether it's a Hope this conversations is helping more than it's hurting @sorvell. Let me know which way I can move forward on this! |
Fixes #290. The previous private `_validate` method has been made protected and named `performUpdate`. It's all now possible to return a promise from this method and doing so will block the update's completion until the promise is resolved. This allows control over the timing of update and integration with schedulers. Fixes #258. Updates are now deferred until element connection. This ensures that microtask checkpoints that may occur during element construction do not generate errors or cause extra update cycles.
* Adds `performUpdate` and defers update until connection Fixes #290. The previous private `_validate` method has been made protected and named `performUpdate`. It's all now possible to return a promise from this method and doing so will block the update's completion until the promise is resolved. This allows control over the timing of update and integration with schedulers. Fixes #258. Updates are now deferred until element connection. This ensures that microtask checkpoints that may occur during element construction do not generate errors or cause extra update cycles. * Format. * Address review feedback. * Address review feedback.
These are useful extension points for scheduling rendering so they should be protected.
The text was updated successfully, but these errors were encountered: