Replace os.rename with shutil.move

[a613]

Summary

In some cases where multiple mounts are used, the code crashes with [Errno 18] Invalid cross-device link. For example, Codeship build servers are designed in a way that causes this problem.

As mentioned in a few places online (see below) one solution is to use shutil.move instead of os.rename, and that is the change that this pull request makes.

Caution

One difference between os.rename and shutil.move is described in pip pull request #103. Apparently the former creates directories as needed but the latter does not. I am not knowledgable enough about terrarium to decide if that is a problem.

See Also

• https://mail.python.org/pipermail/python-list/2005-February/342893.html
• http://stackoverflow.com/questions/11578443/trigger-io-errno-18-cross-device-link

[winhamwr]

A testcase exhibiting the crash would make this ready to merge in.

[a613]

How and why would a test deal with multi-mount transfers? It can be done by hand. I know it works - I had a dependency on this branch that is still operating today.

[kylegibson]

This functionality is available in the 2.0.0-alpha release and will be available for the full 2.0.0 release.