From 2e42ee13ed7f7478a81c77547e5a5461e089e8d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ernesto=20Garc=C3=ADa?= Date: Thu, 29 Aug 2024 14:21:32 -0600 Subject: [PATCH 1/2] Make padding skip clear in Base64URL encoding --- contracts/utils/Base64.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/utils/Base64.sol b/contracts/utils/Base64.sol index 4a0b313f9b9..bc833385b96 100644 --- a/contracts/utils/Base64.sol +++ b/contracts/utils/Base64.sol @@ -22,7 +22,7 @@ library Base64 { } /** - * @dev Converts a `bytes` to its Bytes64Url `string` representation. + * @dev Converts a `bytes` to its Bytes64Url `string` representation. Skips `=` padding. */ function encodeURL(bytes memory data) internal pure returns (string memory) { return _encode(data, _TABLE_URL, false); From 7e0425902611f933dfa254cd0e9509b01cf09e4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ernesto=20Garc=C3=ADa?= Date: Tue, 3 Sep 2024 09:08:32 -0600 Subject: [PATCH 2/2] Accept review suggestions --- contracts/utils/Base64.sol | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contracts/utils/Base64.sol b/contracts/utils/Base64.sol index bc833385b96..c4af3d43d43 100644 --- a/contracts/utils/Base64.sol +++ b/contracts/utils/Base64.sol @@ -22,7 +22,8 @@ library Base64 { } /** - * @dev Converts a `bytes` to its Bytes64Url `string` representation. Skips `=` padding. + * @dev Converts a `bytes` to its Bytes64Url `string` representation. + * Output is not padded with `=` as specified in https://www.rfc-editor.org/rfc/rfc4648[rfc4648]. */ function encodeURL(bytes memory data) internal pure returns (string memory) { return _encode(data, _TABLE_URL, false);