-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Game tag System #40
base: master
Are you sure you want to change the base?
Conversation
src/main/java/net/minestom/server/network/packet/server/common/TagsPacket.java
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine, however we need to have game event tags implemented
tagsMap.put(NamespaceID.from(EntityTag.IDENTIFIER), new ArrayList<>(EntityTag.values())); | ||
// tagsMap.put(NamespaceID.from(GameEventTag.IDENTIFIER), new ArrayList<>(GameEventTag.values())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While Minecraft protocol allows us to register a game event tag, we need to implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we don't have a registry currently. Can you send a proof ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we don't have a registry currently. Can you send a proof ?
Sure,
https://wiki.vg/Protocol#Update_Tags_.28configuration.29
Proposed changes
Fixes #39
This PR aims to replace the old game tag system from Minestom. The old system did not use generation, but a hybrid. During testing it was noticed that this causes errors.
By adding a generic tag structure to read all values from the files, we make it easier to generate the tags
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...