Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OGGM "time format" should be clearer #348

Closed
fmaussion opened this issue Nov 9, 2017 · 1 comment · Fixed by #352
Closed

The OGGM "time format" should be clearer #348

fmaussion opened this issue Nov 9, 2017 · 1 comment · Fixed by #352

Comments

@fmaussion
Copy link
Member

Because of the infamous pandas time limitation there are several time "formats" in OGGM:

  • when working with CRU, we use the default pandas/xarray functionalities
  • with CESM data we have to do more tricks in between but still store the data in a CF compliant format (in "units since ..."). This implies that we assume that CESM actually uses a real calendar (i.e. with leap years and stuff) although I'm not sure if this is the case
  • for the runs, we then get rid of these calendar formats because they are annoying and use a "float year" format. (https://github.com/OGGM/oggm/blob/master/oggm/utils.py#L1085-L1113)

At the very least I will rename this "year" format to the more explicit "float year" name.

Better would be to document all these things somewhere

@anoukvlug
Copy link
Collaborator

The CESM-LME uses a noleap calendar, but both calendars with leap and no leap years can be used by CESM: http://www.cesm.ucar.edu/models/cesm1.2/cesm/doc/usersguide/x1923.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants