Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch revision from package version #74494

Open
davidak opened this issue Nov 28, 2019 · 3 comments
Open

Remove patch revision from package version #74494

davidak opened this issue Nov 28, 2019 · 3 comments
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Comments

@davidak
Copy link
Member

davidak commented Nov 28, 2019

Issue description

The version should not change when patches are applied. See #73228 (comment) for reference on the topic.

There are some packages that have some addition to the release version number for patches.

This issue is to clean up our metadata.

Steps to reproduce

I have created a list of all versions containing - and _:

https://gist.github.com/davidak/54c8222e63b229a30574d6e0a1263125

But in many cases it seems to be the upstream version.

@danbst
Copy link
Contributor

danbst commented Dec 16, 2019

Is this issue about cleanup of version attribute or cleanup of derivation name?

@davidak
Copy link
Member Author

davidak commented Dec 17, 2019

The goal is that the version attribute matches the upstream release version.

@stale
Copy link

stale bot commented Jun 14, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Development

No branches or pull requests

2 participants