-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use appendToName in all-packages.nix #68519
Labels
Comments
If you want to ensure it is kept it needs to be part of the derivation, which means it triggers a rebuild (which I think is typically fine for the use case). |
The vast majority that I quickly checked should simply use |
This comment was marked as off-topic.
This comment was marked as off-topic.
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jun 2, 2020
This comment was marked as off-topic.
This comment was marked as off-topic.
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jun 2, 2020
This comment was marked as off-topic.
This comment was marked as off-topic.
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Nov 29, 2020
This can still be seen in some places:
|
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jan 21, 2021
This comment was marked as off-topic.
This comment was marked as off-topic.
stale
bot
added
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Jul 20, 2021
stale
bot
removed
the
2.status: stale
https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
label
Feb 14, 2022
This was referenced Feb 14, 2022
This was referenced Feb 22, 2022
Merged
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
As noticed in repology/repology-updater#854 (comment), some packages use
appendToName
inall-packages.nix
to distinguish variants bynix-env
.nixpkgs/pkgs/top-level/all-packages.nix
Line 2036 in 848ea3a
We should move that
name
modification to the package expression itself so that the package name is always the same when doing.override { enableStandardFeatures = true; }
.cc @volth
The text was updated successfully, but these errors were encountered: