Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement versioning for both Make and CMake #4

Closed
lukeyeager opened this issue Jun 10, 2015 · 2 comments
Closed

Implement versioning for both Make and CMake #4

lukeyeager opened this issue Jun 10, 2015 · 2 comments
Labels
versioning

Comments

@lukeyeager
Copy link
Member

Versioning added to the Make path in 18a3ff4.

We need it for the CMake path, too. Ideally, both build systems should read from the same file to get the version.

A stub for this has already been created for CMake (which may or may not be helpful):
https://github.com/NVIDIA/caffe/blob/rc2/cmake/Summary.cmake#L58-L86
@lukeyeager
Copy link
Member Author

First attempt made at #6.

It's a hack, but it's a step in the right direction.

@lukeyeager
Copy link
Member Author

This has been done for a while. The versioning code has also been upstreamed to BVLC with BVLC#3311.

@ttheekshanaw ttheekshanaw mentioned this issue Mar 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
versioning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukeyeager