forked from mom-ocean/MOM6
-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
+Dimensional rescaling of user OBC test cases
Add dimensional rescaling of user OBC test cases, including documentation of the units of variables in the Kelvin, shelfwave, tidal_bay and dyed_channel initialization and rescaling parameters parameters via optional scale arguments to get_param calls. These changes also incorporate the answer-changing correction to the Kelvin wave OBC test case in PR mom-ocean#1406, with a comment noting what seems like an additional bug in this test case. This commit includes adding a unit_scale_type argument to call_OBC_register, register_file_OBC, register_tidal_bay_OBC, register_Kelvin_OBC, register_shelfwave_OBC and register_dyed_channel_OBC. These Kelvin wave OBC configuration from ESMG-configs now passes the dimensional rescaling tests. All answers are bitwise identical in the MOM6_examples test cases, but there are interface changes.
- Loading branch information
1 parent
1562e8f
commit 29061de
Showing
7 changed files
with
145 additions
and
116 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.