Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy/Procedure to merge mixed mode (precision) FMS into GFDL main #959

Closed
MinsukJi-NOAA opened this issue Apr 13, 2022 · 5 comments · Fixed by #997
Closed

Strategy/Procedure to merge mixed mode (precision) FMS into GFDL main #959

MinsukJi-NOAA opened this issue Apr 13, 2022 · 5 comments · Fixed by #997
Labels

Comments

@MinsukJi-NOAA
Copy link
Contributor

@thomas-robinson @jiandewang @junwang-noaa @binli2337 @laurenchilutti @bensonr

Discuss and plan how to go about merging the mixed mode FMS into GFDL main.
This issue gets complicated since these changes need to go in at the same time as accompanying PR's in MOM6 and GFDL_atmos_cubed_sphere repositories.

References:

@MinsukJi-NOAA
Copy link
Contributor Author

@thomas-robinson @rem1776 NOAA-EMC/FMS/tree/fms_mixedmode is up to date with GFDL FMS main (689579e).

Would it be a good idea to create a new branch off of the current main, to which I can make a pull request? Or do I make a pull request to the outdated emc_mixedmode branch?

@rem1776
Copy link
Contributor

rem1776 commented Apr 15, 2022

@MinsukJi-NOAA You can make the pull request to the emc_mixedmode branch, I just updated it to be up to date with FMS main.

@MinsukJi-NOAA
Copy link
Contributor Author

@rem1776 A PR has been made to the emc_mixedmode branch.

@rem1776
Copy link
Contributor

rem1776 commented Apr 28, 2022

linking this related issue for the accompanying changes
ufs-community/ufs-weather-model#1036

@junwang-noaa
Copy link

@rem1776 @thomas-robinson @laurenchilutti @bensonr Now the required code changes in MOM6 was merged. May I ask if there is a plan to merge the FMS updates to GFDL main branch? We need this capability for the next GFSv17 coupled test. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants