-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3timemd.F90 time issue with Index '52' of dimension 1 of array 'ndpm' above upper bound of 12 #1109
Comments
Related issue: ufs-community/ufs-weather-model#1963 |
While this was only discovered in the UFS coupled model & dev/ufs-weather-model branch. I believe this issue is also in develop and depending on how your compiler initalizes uninitialized variables could or could not cause issues for you. Here's the longer story: Why is it uninitialized? However, we only initialize in w3init for up to NOTYPE and for TONEXT=8: https://github.com/NOAA-EMC/WW3/blob/dev/ufs-weather-model/model/src/w3initmd.F90#L1049-L1070
Note NOTYPE is either 6 or 7, in our case 6 because we do not use W3_COU ie w3_cou_flag=false:
or for ww3_shel:
To fix this I need to figure out how to properly initialize TONEXT(:,7) or to never use TONEXT(:,7) if FLOUT(7)=.false. My proposed fix is to change:
to:
We will be getting a hot-fix to the dev/ufs-weather-model branch after successful tests. The machine with the compiler combination that exposed this issue is on maintenance today, so I will have to wait to test the fix there. In the meantime, I'll also get a PR ready for the develop branch and start standalone WW3 testing as well. |
I was looking at this issue a couple of months ago (but unfortunately I have been hiding it in a question #1026 where I focused on some errors I did at the same time in loading the correct libraries with new versions of our GNU and Intel compilers). I would suggest to use the logicals FLOUTG and FLOUTG2 which are set a few code lines before in https://github.com/NOAA-EMC/WW3/blob/3eb8161fdc999f4046fac7d77febff70c399c4f8/model/src/w3wavemd.F90#L2381C1-L2391C15 and change
to
|
@CarstenHansen thanks for the great suggestion! I'll try this out. |
Have the updates in a branch with the suggested fix from @CarstenHansen : https://github.com/JessicaMeixner-NOAA/WW3/tree/bug/flout7uninit_new and testing has just started. |
Describe the bug
A bug was found in WW3 when running ufs-weather-model with gnu on hercules. This was found by @climbfuji :
To Reproduce
Run ufs-weather-model. - Note this is the dev/ufs-weather-model branch, but potentially is also an issue in develop.
Expected behavior
Should be able to run in debug mode with gnu
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: