Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dimensions for array delz in two diagnostic routines #28

Closed
climbfuji opened this issue Jun 26, 2020 · 3 comments
Closed

Incorrect dimensions for array delz in two diagnostic routines #28

climbfuji opened this issue Jun 26, 2020 · 3 comments

Comments

@climbfuji
Copy link

The previous dycore merge changed the dimensions of delz from

delz(is-ng:ie+ng,js-ng:je+ng,:)

to

delz(is:ie,js:je,:)

This change was overlooked in two diagnostic routines in tools/fv_diagnostics.F90. This triggered run-to-run differenes in the purely diagnostic output of maximum vorticity etc. It could potentially also lead to segmentation faults.

This is addressed in PR #27.
@climbfuji climbfuji mentioned this issue Jun 26, 2020
Closed
@climbfuji
Copy link
Author

@bensor @junwang-noaa @DusanJovic-NOAA @XiaqiongZhou-NOAA

@climbfuji climbfuji mentioned this issue Jun 29, 2020
Merged
@climbfuji
Copy link
Author

Fixed by #30 for dev/emc.

@climbfuji
Copy link
Author

This PR was pulled into, amended and merged as part of #30 for dev/emc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climbfuji