Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARBL_tools should use case-insensitive string compares #208

Closed
mnlevy1981 opened this issue Dec 4, 2017 · 2 comments
Closed

MARBL_tools should use case-insensitive string compares #208

mnlevy1981 opened this issue Dec 4, 2017 · 2 comments
Milestone
MARBL1.0.0

Comments

@mnlevy1981
Copy link
Collaborator

When generating a MARBL_settings_class object, case should not matter for the variable names in the user-provided setting input file.

We have a Fortran-based string comparison in src/marbl_settings_mod.F90 (the function case_insensitive_eq) but we need something similar for the Python code as well.
@mnlevy1981 mnlevy1981 mentioned this issue Dec 4, 2017
Merged
@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Dec 4, 2017
@mnlevy1981
Copy link
Collaborator Author

Rather than case-insensitive comparisons, I just use varname.lower() for keys in the input file dictionary

@mnlevy1981
Copy link
Collaborator Author

Fixed in marbl0.26.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MARBL1.0.0
Development

No branches or pull requests
1 participant
@mnlevy1981