Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of unnecessary abstractions #358

Open
alexdunnjpl opened this issue Aug 30, 2022 · 0 comments
Open

Removal of unnecessary abstractions #358

alexdunnjpl opened this issue Aug 30, 2022 · 0 comments
Assignees
Labels

Comments

@alexdunnjpl
Copy link
Contributor

💪 Motivation

As a developer, abstractions increase complexity (often significantly) and should therefore be motivated by an concrete payoff.

📖 Additional Details

For example, doi-service provides abstractions to allow arbitrary output endpoints, but support for more than a single endpoint is no longer a need and is not foreseen as a possible future need. Ergo, these abstractions are no longer as justified as they might have been in the past.

@alexdunnjpl to propose changes in comments. @tloubrieu-jpl to accept/reject proposed changes. @alexdunnjpl to nuke accepted targets from orbit.

⚖️ Acceptance Criteria

The resulting code still passes unit tests.

⚙️ Engineering Details

This work will need to be implemented in as granular a manner as possible, preferably while no other work is being done. All PRs affecting pds_doi_service.core should be merged before implementation.

@alexdunnjpl alexdunnjpl added requirement the current issue is a requirement needs:triage labels Aug 30, 2022
@jordanpadams jordanpadams added enhancement New feature or request icebox skip-i&t and removed requirement the current issue is a requirement labels Aug 30, 2022
@jordanpadams jordanpadams removed their assignment Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Development

No branches or pull requests

3 participants