Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bobbing causes weird shift in lighting #3881

Closed
Cervator opened this issue Apr 7, 2020 · 2 comments
Closed

Bobbing causes weird shift in lighting #3881

Cervator opened this issue Apr 7, 2020 · 2 comments
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems
Milestone

Comments

@Cervator
Copy link
Member

Cervator commented Apr 7, 2020

What you were trying to do

Test something unrelated. One would normally expect to be able to move around the world with consistent lighting/shadows

What actually happened

Only when walking with the "bobbing" gfx turned on: the lighting shifts subtly for each "bob" (every few steps). Doesn't happen if flying or if you turn off the effect.

How to reproduce

  • Run game normally and enter a world with "bobbing" enabled
  • Move forward, ideally with a hill or something in front of you
  • Observe subtle lighting shifts in tune with the head bobbing

Note:: It may be specific to time of day in-game - seemed to not happen in some cases but around World Time 0.5 it was strongly present.

It may relate to the recent JOML changes as I cannot replicate with the commit immediately preceding #3811 - but I haven't tested after that point commit-by-commit. @PS-Soundwave suspected as much, but upgrading to 1.9.23 from 1.9.19 didn't seem to have an effect.

Screenies

Easier to see the effect in-game, but it is there

Terasology-200406221929-1152x720

Terasology-200406221928-1152x720

@Cervator Cervator added Type: Bug Issues reporting and PRs fixing problems Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. labels Apr 7, 2020
@pollend
Copy link
Member

pollend commented Apr 8, 2020

I think #3885 resolves this.

@Cervator
Copy link
Member Author

Cervator commented Apr 8, 2020

Looks like! Thanks hunting it down :-)

@Cervator Cervator closed this as completed Apr 8, 2020
@Cervator Cervator added this to the v3.0.1 milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

No branches or pull requests

2 participants