From 3824bbff7a8c4ced4285ef6d0c2d1e5752eb0397 Mon Sep 17 00:00:00 2001 From: Kevin Turner <83819+keturn@users.noreply.github.com> Date: Sat, 7 Aug 2021 20:29:18 -0700 Subject: [PATCH] doc(DisplayMetricsMonitor): comments on use of micrometer interfaces --- .../engine/monitoring/DisplayMetricsMonitor.java | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/engine/src/main/java/org/terasology/engine/monitoring/DisplayMetricsMonitor.java b/engine/src/main/java/org/terasology/engine/monitoring/DisplayMetricsMonitor.java index d22a1ee76cb..cce37c6e05e 100644 --- a/engine/src/main/java/org/terasology/engine/monitoring/DisplayMetricsMonitor.java +++ b/engine/src/main/java/org/terasology/engine/monitoring/DisplayMetricsMonitor.java @@ -4,8 +4,8 @@ package org.terasology.engine.monitoring; import io.micrometer.core.instrument.Clock; -import io.micrometer.core.instrument.logging.LoggingRegistryConfig; import io.micrometer.core.instrument.step.StepMeterRegistry; +import io.micrometer.core.instrument.step.StepRegistryConfig; import java.time.Duration; import java.util.concurrent.TimeUnit; @@ -15,7 +15,15 @@ public class DisplayMetricsMonitor extends StepMeterRegistry { public static final Duration captureDuration = Duration.ofSeconds(1); public DisplayMetricsMonitor() { - super(new LoggingRegistryConfig() { + // micrometer doesn't provide concrete implementations of these Config classes. + // We don't need to vary this configuration or load it from an external source, + // so we define it using an anonymous class here. + super(new StepRegistryConfig() { + @Override + public String prefix() { + return "display"; + } + @Override public String get(String key) { return null; @@ -30,7 +38,7 @@ public Duration step() { @Override protected void publish() { - + // We don't need to push records anywhere. The view polls the current values; past steps are discarded. } @Override