Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass/fail reports are not visually distinct enough to tell apart at a glance #404

Closed
Atemu opened this issue Jun 17, 2024 · 1 comment · Fixed by #414
Closed

Pass/fail reports are not visually distinct enough to tell apart at a glance #404

Atemu opened this issue Jun 17, 2024 · 1 comment · Fixed by #414

Comments

@Atemu
Copy link
Contributor

Atemu commented Jun 17, 2024

In NixOS/nixpkgs#318912 @siraben posted a nixpkgs-review but nobody noticed that the nixpkgs-review text said that the build has failed. Luckily, it was just a fluke but this shouldn't happen. A failure should be obvious and not easily confused with a pass.

To improve nixpkgs-review in this regard, I propose usage of obviously distinct visual patterns for pass and failed such as emboldening failed or adding an emoji.

I don't typically use them but I think Emoji could really shine here as they feature bright obvious colours and distinct shapes.

Does that sound good?

@Atemu Atemu changed the title Pass/fail reports are not distinct enough to tell apart at a glance Pass/fail reports are not visually distinct enough to tell apart at a glance Jun 17, 2024
@Mic92
Copy link
Owner

Mic92 commented Jun 17, 2024

Sure. Let's add some 🔥 or something else: https://gist.github.com/rxaviers/7360908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants