Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Upload of empty files #851

Closed
charlesangus opened this issue Sep 9, 2020 · 3 comments · Fixed by #890
Closed

Crash on Upload of empty files #851

charlesangus opened this issue Sep 9, 2020 · 3 comments · Fixed by #890
Assignees
Labels
bug data corruption - sync failure - crash - anr The most critical classification sync Integration with Mergin Maps backend

Comments

@charlesangus
Copy link

Uploading from a simple project crashes the app. Restarting Input and trying to upload again results in a popup saying, "Another process is running. Please try again later."

Project has two editable layers, a point layer and a line layer. The point layer has photos attached.

A simpler project with just an editable point layer uploads fine.

@wonder-sk
Copy link
Contributor

What platform is it - Android or iOS ? Could you please share the project folder you are trying to sync? Also, there is a hidden file in INPUT/projects/.logs - it would be useful if you could send it as well - there may be some valuable information from the previous failed sync. If your data are private, feel free to send them to me at martin.dobias@lutraconsulting.co.uk

Regarding "Another process is running" message - that happens when server thinks there is a pending upload - here it's before the upload crashed. The project will get unlocked in 5 minutes and it should be possible to sync again.

@charlesangus
Copy link
Author

This is Android 10. I have sent the project folder and the .logs file to the email specified. Thanks!

@wonder-sk
Copy link
Contributor

Thanks for the project folder + logs file. I can confirm a crash on sync which prevents uploads of any changes. The reason is that there are empty files which Input wants to push, but crashes before doing that:

#4  0x00005555555aace9 in QList<QString>::at(int) const (this=0x7fffffffcbe0, i=0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:544
#5  0x00005555555b1222 in MerginApi::uploadFile(QString const&, QString const&, MerginFile, int)
    (this=0x555555b576d0, projectFullName=..., transactionUUID=..., file=..., chunkNo=0) at ../app/merginapi.cpp:290
#6  0x00005555555bf0b5 in MerginApi::uploadFileReplyFinished() (this=0x555555b576d0) at ../app/merginapi.cpp:1514

In MerginApi::uploadFile() we try to get the first chunk, but file.chunks is actually an empty list which causes the crash.

@wonder-sk wonder-sk added sync Integration with Mergin Maps backend data corruption - sync failure - crash - anr The most critical classification labels Sep 23, 2020
@wonder-sk wonder-sk modified the milestone: 0.7.0 Sep 23, 2020
@wonder-sk wonder-sk changed the title Crash on Upload Crash on Upload of empty files Sep 23, 2020
@tomasMizera tomasMizera self-assigned this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data corruption - sync failure - crash - anr The most critical classification sync Integration with Mergin Maps backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants