Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button obscured #384

Closed
mostlyAtNight opened this issue Jul 16, 2019 · 2 comments · Fixed by #1201
Closed

Save button obscured #384

mostlyAtNight opened this issue Jul 16, 2019 · 2 comments · Fixed by #1201
Assignees
Labels
bug ui/ux Related to user interface

Comments

@mostlyAtNight
Copy link
Contributor

Check this:

image

I've now finished editing attribute data and want to go back to the map (saving my work). The obvious button that's visible is 'Back' but if I press that, my point is lost (I have done this many times by accident). To save I have the (1) minimise the KB then (2) hit save.

Perhaps we can put the save button at the top of the page so we have either 'Save' or 'Cancel' there?

@wonder-sk
Copy link
Contributor

@mostlyAtNight How about that upon clicking "Back" we would check if there are any changes to attributes, and if there are, we would ask the user whether to save the changes [yes] / [no] / [cancel]

That would avoid the need to have the bottom toolbar always visible (taking up vertical space) and also avoid having to move the controls around...?

@wonder-sk wonder-sk added bug forms related to attribute forms ui/ux Related to user interface and removed forms related to attribute forms labels Aug 6, 2019
@wonder-sk
Copy link
Contributor

Currently the idea to solve this is to have Cancel/Save buttons in the header, so they are always visible:

image

This should also avoid the common source of problems when users edit something, then click back button, forgetting to save the changes. With this approach they would explicitly choose whether to save or discard changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ui/ux Related to user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants