Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues about Channel-wise Correlation #2

Open
shuaiyongjiang opened this issue May 14, 2023 · 2 comments
Open

issues about Channel-wise Correlation #2

shuaiyongjiang opened this issue May 14, 2023 · 2 comments

Comments

@shuaiyongjiang
Copy link

In Channel-wise Correlation Module(line 97):

  exemplar_att = exemplar_att.view(-1, self.channel, fea_size[0], fea_size[1])  # N,C1,H*W -> N,C1,H,W
  exemplar_out = self.conv1(exemplar_att + exemplar)

  query_att = query_att.view(-1, self.channel, fea_size[0], fea_size[1])  # N,C2,H*W -> N,C2,H,W
  query_out = self.conv1(query_att + query)

two "self.conv1" are sharing weight?

@MathLee
Copy link
Owner

MathLee commented May 14, 2023

Thanks for pointing out this issue. This is our mistake.
"query_out = self.conv1(query_att + query)" should be "query_out = self.conv2(query_att + query)".

@MathLee
Copy link
Owner

MathLee commented May 14, 2023

This mistake is an engineering code error and will not affect our motivation to design the network. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants