Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musings on the fourier series #519

Open
mathause opened this issue Sep 4, 2024 · 1 comment
Open

musings on the fourier series #519

mathause opened this issue Sep 4, 2024 · 1 comment

Comments

@mathause
Copy link
Member

mathause commented Sep 4, 2024

To make sure my findings on the fourier series is not lost in some random PR I gather them here as per @veni-vidi-vici-dormivi suggestion 😉

  1. The fourier series is related to the fft: minimizing the least squares difference of a fourier series yields the "same" (by a scaling factor) coefficients as an fft.
  2. The fft does not have any covariates (in contrast to our approach of the fourier series) - so we cannot use fft instead of our minimization.
  3. However, we could use the fft to get a better first guess for the constant part of our fourier series.
  4. We test for each order if it minimizes the BIC. However, we don't test if adding the covariates does so. I am not 100% sure how to best do that... Maybe "order 1, no covariates", "order 1, covariates", etc.. But let's say if "order 2, covariates" does not provide additional benefit - do we stop or do we test "order 3, no covariates"? No idea...

For points 1 through 3: see #512 (comment)

@mathause
Copy link
Member Author

mathause commented Sep 5, 2024

  1. One thing I am unsure about: we only fit the fourier series for whole frequencies. Is that a good approach? Should we also use other frequencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants