Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-youtube-iframe does not support vertical videos #136

Closed
oussamaraboija opened this issue Apr 23, 2021 · 3 comments
Closed

react-native-youtube-iframe does not support vertical videos #136

oussamaraboija opened this issue Apr 23, 2021 · 3 comments

Comments

@oussamaraboija
Copy link

I'm using the package correctly and it is working great with auto play, but we have a vertical video we want to use that introduces our app.

Using a vertical video works well in full screen, but in the iframe you cannot make it vertical, changing the height and width to a vertical aspect ration just make the webView handling the iframe taller.

      <YoutubePlayer
        height={600}
        width={350}
        play={playing}
        videoId={'yabDCV4ccQs'}
        onChangeState={onStateChange}
      />

There is no way to support vertical videos in the docs either.

@LonelyCpp
Copy link
Owner

yeah, the player defaults to a 16:9 aspect ratio.

try #13 (comment) to expand the player to any height

@oussamaraboija
Copy link
Author

Thank you so much 🙏, I suggest we add this as a prop like isVertical to the library. It is working well.

@LonelyCpp
Copy link
Owner

definitely. I'll update in #64 when it's done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants