Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Signature of training_end, validation_end, test_end in Experimet Reporing #870

Closed
xssChauhan opened this issue Feb 16, 2020 · 1 comment · Fixed by #871
Closed

Incorrect Signature of training_end, validation_end, test_end in Experimet Reporing #870

xssChauhan opened this issue Feb 16, 2020 · 1 comment · Fixed by #871
Labels
docs Documentation related
Milestone
pl:0.7

Comments

@xssChauhan
Copy link
Contributor

📚 Documentation

Documentation here defines the signature of the functions as follows:
training_end(self, outputs)
test_end(self, outputs)
validation_end(self, outputs)

While in the Experiment Reporting section of docs, the signature of the functions has been misreported as:
training_end(self, batch, batch_idx)
test_end(self, batch, batch_idx)
validation_end(self, batch, batch_idx)
@xssChauhan xssChauhan added docs Documentation related typo labels Feb 16, 2020
@github-actions
Copy link
Contributor

Hi'! thanks for your contribution!, great first issue!

@xssChauhan xssChauhan mentioned this issue Feb 16, 2020
Merged
4 tasks
@Borda Borda added this to the 0.6.1 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging a pull request may close this issue.

Fixing Function Signatures xssChauhan/pytorch-lightning
2 participants
@Borda @xssChauhan