Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overfit_pct vs train_percent_check etc #830

Closed
ghost opened this issue Feb 13, 2020 · 1 comment · Fixed by #2213
Closed

overfit_pct vs train_percent_check etc #830

ghost opened this issue Feb 13, 2020 · 1 comment · Fixed by #2213
Assignees
Labels
docs Documentation related feature Is an improvement or enhancement
Milestone

Comments

@ghost
Copy link

ghost commented Feb 13, 2020

As far as I can make out, the (only?) purpose of overfit_pct is to overwrite the values of train_percent_check, val_percent_check, and test_percent_check. If that is the case, then I think we should

  • make the names more similar (e.g. data_percent_check)
  • move the positions of the arguments closer together (so that it suggests a relation)
  • update the docs to reflect that (I found the docs confusing)

Also, the default value should not be 0.0 but None.

Another option would be to drop it completely for the sake of simplification. Not sure.

@ghost ghost added the typo label Feb 13, 2020
@Borda Borda removed the typo label Feb 19, 2020
@williamFalcon
Copy link
Contributor

@ghost want to submit a PR?

@Borda Borda added docs Documentation related feature Is an improvement or enhancement labels Apr 14, 2020
@Borda Borda self-assigned this Apr 14, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 14, 2020
@Borda Borda modified the milestones: 0.7.4, 0.7.5 Apr 26, 2020
@Borda Borda modified the milestones: 0.7.6, 0.8.0, 0.7.7 May 12, 2020
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@Borda Borda modified the milestones: 0.9.0, 0.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants