Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clip_gradient with clip_grad_value #4927

Closed
ruotianluo opened this issue Dec 1, 2020 · 1 comment · Fixed by #6123
Closed

clip_gradient with clip_grad_value #4927

ruotianluo opened this issue Dec 1, 2020 · 1 comment · Fixed by #6123
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@ruotianluo
Copy link
Contributor

🚀 Feature

The current clip_gradient uses clip_grad_norm; can we add clip_grad_value?
@ruotianluo ruotianluo added feature Is an improvement or enhancement help wanted Open to be worked on labels Dec 1, 2020
@stale
Copy link

stale bot commented Dec 31, 2020

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions, Pytorch Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Dec 31, 2020
@stale stale bot closed this as completed Jan 7, 2021
This was referenced Jan 11, 2021
Closed
Closed
Closed
@dhkim0225 dhkim0225 mentioned this issue Feb 22, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Trainer(gradient_clip_algorithm='value'|'norm') dhkim0225/pytorch-lightning
1 participant
@ruotianluo