Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out CloudRuntime.dispatch into multiple methods #15012

Closed
awaelchli opened this issue Oct 5, 2022 · 2 comments · Fixed by #16456
Closed

Split out CloudRuntime.dispatch into multiple methods #15012

awaelchli opened this issue Oct 5, 2022 · 2 comments · Fixed by #16456
Labels
app (removed) Generic label for Lightning App package good first issue Good for newcomers priority: 2 Low priority task refactor

Comments

@awaelchli
Copy link
Contributor

Proposed refactor

Split out CloudRuntime.dispatch into multiple methods.

Motivation

This makes the code easier to read and test. Specifically, when testing individual setup stages of this runtime, we can mock out individual parts that are irrelevant for execution/testing.

Additional context

This first came up here: #14929


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging PyTorch Lightning, Transformers, and Hydra.

@awaelchli awaelchli added needs triage Waiting to be triaged by maintainers good first issue Good for newcomers refactor app (removed) Generic label for Lightning App package and removed needs triage Waiting to be triaged by maintainers labels Oct 5, 2022
@awaelchli awaelchli modified the milestone: app:0.7 Oct 5, 2022
@awaelchli awaelchli added the priority: 2 Low priority task label Oct 5, 2022
@awaelchli awaelchli changed the title Refactor CloudRuntime.dispatch Split out CloudRuntime.dispatch into multiple methods Oct 5, 2022
@stale
Copy link

stale bot commented Nov 13, 2022

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions - the Lightning Team!

@tanaymeh
Copy link
Contributor

Hi @awaelchli, can I take up this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package good first issue Good for newcomers priority: 2 Low priority task refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants